refactor: Updated apollo server plugin to break out relevant functions into helpers #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 99.04% 98.98% -0.06%
==========================================
Files 4 7 +3
Lines 730 891 +161
==========================================
+ Hits 723 882 +159
- Misses 7 9 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…s into helpers, utilities, and plugin hooks to reduce cognitive complexity
bizob2828
force-pushed
the
refactor-plugin
branch
from
2c2f6e2
to
b2f3f34
Compare
jsumners-nr
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utilities, and plugin hooks to reduce cognitive complexity,
Description
This PR just breaks down the 1 big file of
lib/create-plugin.jsinto other files that contain the apollo lifecycle hook implementation, utilities, and helpers for creating relevant segments, transaction, errors, etc. By breaking this down it reduced the cognitive complexity.Related Issues
Closes NR-134583