Add instrumentation for gRPC 1.40.0+ #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Hello ! I noticed the issue for compatibility with gRPC
1.40.0+
, and just thought I'd contribute.I took inspiration from #92, which added support of gRPC
1.30.0
.The only difference with the
1.30.0
instrumentation is the classServerImpl_Instrumentation
, where thestartCall()
method was replaced by thewrapMethod()
method. Indeed thestartCall()
method was refactored in this commit ingrpc-java
repo.I also manually tested it in a project at work, and it seems to work fine.
Quick notes:
build.gradle
, line 36, I used the latest available gRPC version (1.41.0
), however I kept version1.40.1
in the dependencies (as it's the first version the instrumentation is compatible with). I'm not sure if I should use the same version or not ?Related Github Issue
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
io.grpc:grpc-all