Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kinesis Data Streams ARNs [DO NOT MERGE UNTIL CLOUD API MERGED] #2112

Merged
merged 24 commits into from
Oct 30, 2024

Conversation

obenkenobi
Copy link
Contributor

Overview

Do not merge until the Cloud API PR is merged.

Add ARNs for AWS Kinesis spans pointing to specific AWS streams using the span attribute cloud.resource_id.

Related Github Issue

#2071

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 80.85106% with 63 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (bbb433f) to head (78cdd53).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
...om/newrelic/agent/cloud/CloudAccountInfoCache.java 70.73% 7 Missing and 5 partials ⚠️
...nt/SuperAgentIntegrationHealthFileBasedClient.java 76.66% 4 Missing and 3 partials ⚠️
...c/agent/superagent/SuperAgentIntegrationUtils.java 64.70% 5 Missing and 1 partial ⚠️
...ava/com/newrelic/agent/utilization/DockerData.java 64.70% 4 Missing and 2 partials ⚠️
...in/java/com/newrelic/agent/cloud/CloudApiImpl.java 68.75% 5 Missing ⚠️
...gent/config/SuperAgentIntegrationHealthConfig.java 70.58% 4 Missing and 1 partial ⚠️
.../agent/config/SuperAgentIntegrationConfigImpl.java 82.35% 0 Missing and 3 partials ⚠️
...va/com/newrelic/agent/environment/Environment.java 40.00% 2 Missing and 1 partial ⚠️
...a/com/newrelic/agent/transport/DataSenderImpl.java 78.57% 3 Missing ⚠️
...ewrelic/agent/cloud/CloudAccountInfoValidator.java 85.71% 1 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2112      +/-   ##
============================================
+ Coverage     70.58%   70.65%   +0.07%     
- Complexity     9877     9962      +85     
============================================
  Files           829      840      +11     
  Lines         39947    40253     +306     
  Branches       6079     6106      +27     
============================================
+ Hits          28197    28442     +245     
- Misses         9021     9065      +44     
- Partials       2729     2746      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,101 @@
package com.agent.instrumentation.awsjavasdk12.services.kinesis;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name awsjavasdk12? Guess you didn't delete the 2 when refactoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional. I just kept the package names different so intellij does not get confused when I do debugging.

@obenkenobi obenkenobi merged commit e5db35c into main Oct 30, 2024
111 checks passed
@meiao meiao deleted the kinesis-arn branch December 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants