-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kinesis Data Streams ARNs [DO NOT MERGE UNTIL CLOUD API MERGED] #2112
Conversation
Update documentation to inform the behavior
...rc/main/java/com/agent/instrumentation/awsjavasdk1/services/kinesis/StreamProcessedData.java
Outdated
Show resolved
Hide resolved
agent-bridge/src/main/java/com/newrelic/agent/bridge/Agent.java
Outdated
Show resolved
Hide resolved
....106/src/main/java/com/agent/instrumentation/awsjavasdk1/services/kinesis/StreamRawData.java
Outdated
Show resolved
Hide resolved
...11.106/src/main/java/com/agent/instrumentation/awsjavasdk1/services/kinesis/KinesisUtil.java
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,101 @@ | |||
package com.agent.instrumentation.awsjavasdk12.services.kinesis; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package name awsjavasdk12
? Guess you didn't delete the 2 when refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional. I just kept the package names different so intellij does not get confused when I do debugging.
Overview
Do not merge until the Cloud API PR is merged.
Add ARNs for AWS Kinesis spans pointing to specific AWS streams using the span attribute
cloud.resource_id
.Related Github Issue
#2071