Skip to content

fix: Revert "Generate PTID in Agent" #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: Revert "Generate PTID in Agent" #976

merged 1 commit into from
Apr 15, 2024

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Apr 15, 2024

Revert a change causing Trace to begin harvest even when the rum flag given is 0.

Overview

This reverts commit af7b676.

Related Issue(s)

Escalation https://newrelic.slack.com/archives/C0193KAHHAS/p1713186294566949 & #emergency-room on 15/4/2024

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.19 kB / 10.94 kB (gzip) 31.17 kB / 10.93 kB (gzip) -0.08% / -0.14% (gzip)
lite async-chunk 51.6 kB / 16.73 kB (gzip) 51.56 kB / 16.71 kB (gzip) -0.08% / -0.1% (gzip)
pro loader 50.99 kB / 17.35 kB (gzip) 50.97 kB / 17.34 kB (gzip) -0.05% / -0.03% (gzip)
pro async-chunk 93.79 kB / 28.68 kB (gzip) 93.81 kB / 28.67 kB (gzip) 0.02% / -0.05% (gzip)
spa loader 59.56 kB / 19.94 kB (gzip) 59.53 kB / 19.93 kB (gzip) -0.04% / -0.06% (gzip)
spa async-chunk 108.26 kB / 32.9 kB (gzip) 108.28 kB / 32.88 kB (gzip) 0.02% / -0.03% (gzip)
lite-polyfills loader 125.15 kB / 40.23 kB (gzip) 125.13 kB / 40.22 kB (gzip) -0.02% / -0.02% (gzip)
lite-polyfills async-chunk 66.29 kB / 19.07 kB (gzip) 66.25 kB / 19.05 kB (gzip) -0.06% / -0.07% (gzip)
pro-polyfills loader 145.38 kB / 46.23 kB (gzip) 145.35 kB / 46.22 kB (gzip) -0.02% / -0.01% (gzip)
pro-polyfills async-chunk 128.76 kB / 33.54 kB (gzip) 128.77 kB / 33.53 kB (gzip) 0.01% / -0.02% (gzip)
spa-polyfills loader 153.4 kB / 48.37 kB (gzip) 153.38 kB / 48.36 kB (gzip) -0.02% / -0.02% (gzip)
spa-polyfills async-chunk 145.57 kB / 38.16 kB (gzip) 145.58 kB / 38.15 kB (gzip) 0.01% / -0.02% (gzip)

Copy link

Static Badge

Last ran on April 15, 2024 08:45:52 CDT
Checking merge of (95dd3f9) into main (c3e1e09)

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.70%. Comparing base (c3e1e09) to head (95dd3f9).

Files Patch % Lines
src/features/session_trace/aggregate/index.js 7.69% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   83.84%   83.70%   -0.14%     
==========================================
  Files         153      153              
  Lines        7148     7142       -6     
  Branches     1410     1408       -2     
==========================================
- Hits         5993     5978      -15     
- Misses        982      987       +5     
- Partials      173      177       +4     
Flag Coverage Δ
unit-tests 67.36% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24
Copy link
Contributor Author

cwli24 commented Apr 15, 2024

Cannot get someone to check off; for sake of time, bypassing main branch protection
Tests are passing & manually verified new build respects stn flag.

@cwli24 cwli24 merged commit 34b317f into main Apr 15, 2024
44 of 50 checks passed
@cwli24 cwli24 deleted the revert-ptid branch April 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant