Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Aggregate UserActions #1195

Merged
merged 32 commits into from
Oct 1, 2024
Merged

feat: Aggregate UserActions #1195

merged 32 commits into from
Oct 1, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 23, 2024

Utilize sequential aggregation techniques when observing UserAction data to reduce ingest cost for customers.

Overview

This PR extends #1186 and that PR should be merged first. This applies aggregation to sequentially identical events. Identicality is determined by CSS selector path.

Related Issue(s)

Testing

Tests have been updated to check for aggregation behavior

Copy link

github-actions bot commented Sep 23, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.48 kB / 11.03 kB (gzip) 30.48 kB / 11.03 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.57 kB / 16.73 kB (gzip) 51.57 kB / 16.74 kB (gzip) 0.01% / 0.03% (gzip)
pro loader 51.48 kB / 17.78 kB (gzip) 51.5 kB / 17.79 kB (gzip) 0.04% / 0.04% (gzip)
pro async-chunk 97.92 kB / 29.73 kB (gzip) 99.71 kB / 30.47 kB (gzip) 1.83% / 2.5% (gzip)
spa loader 59.13 kB / 20.15 kB (gzip) 59.15 kB / 20.16 kB (gzip) 0.03% / 0.05% (gzip)
spa async-chunk 112.98 kB / 34.08 kB (gzip) 114.78 kB / 34.82 kB (gzip) 1.59% / 2.17% (gzip)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.33028% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (1b0bb1d) to head (77171d0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../aggregate/user-actions/user-actions-aggregator.js 91.66% 3 Missing ⚠️
src/features/generic_events/aggregate/index.js 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   88.45%   88.62%   +0.17%     
==========================================
  Files         164      168       +4     
  Lines        7221     7340     +119     
  Branches     1472     1507      +35     
==========================================
+ Hits         6387     6505     +118     
- Misses        710      712       +2     
+ Partials      124      123       -1     
Flag Coverage Δ
integration-tests 91.85% <100.00%> (+0.14%) ⬆️
unit-tests 78.99% <90.69%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah changed the title UserActions aggregation comparison thread feat: Aggregate UserActions Sep 25, 2024
@metal-messiah metal-messiah changed the base branch from user-actions to main September 25, 2024 17:23
@metal-messiah metal-messiah marked this pull request as ready for review September 25, 2024 17:24
Copy link

github-actions bot commented Sep 25, 2024

Static Badge

Last ran on October 01, 2024 11:53:27 CDT
Checking merge of (77171d0) into main (1b0bb1d)

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just styling/readability & simplification suggestions

cwli24
cwli24 previously approved these changes Sep 30, 2024
Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after tests

@metal-messiah metal-messiah merged commit b5e4c6d into main Oct 1, 2024
31 of 32 checks passed
@metal-messiah metal-messiah deleted the ua-aggregation branch October 1, 2024 17:49
jspivack pushed a commit to jspivack/newrelic-browser-agent that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants