-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Aggregate UserActions #1195
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 88.45% 88.62% +0.17%
==========================================
Files 164 168 +4
Lines 7221 7340 +119
Branches 1472 1507 +35
==========================================
+ Hits 6387 6505 +118
- Misses 710 712 +2
+ Partials 124 123 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just styling/readability & simplification suggestions
src/features/generic_events/aggregate/user-actions/user-actions-aggregator.js
Outdated
Show resolved
Hide resolved
src/features/generic_events/aggregate/user-actions/user-actions-aggregator.js
Show resolved
Hide resolved
src/features/generic_events/aggregate/user-actions/user-actions-aggregator.js
Outdated
Show resolved
Hide resolved
src/features/generic_events/aggregate/user-actions/user-actions-aggregator.js
Outdated
Show resolved
Hide resolved
src/features/generic_events/aggregate/user-actions/aggregated-user-action.js
Show resolved
Hide resolved
src/features/generic_events/aggregate/user-actions/aggregated-user-action.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after tests
Utilize sequential aggregation techniques when observing UserAction data to reduce ingest cost for customers.
Overview
This PR extends #1186 and that PR should be merged first. This applies aggregation to sequentially identical events. Identicality is determined by CSS selector path.
Related Issue(s)
Testing
Tests have been updated to check for aggregation behavior