Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing type declarations #791

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: Fix missing type declarations #791

merged 1 commit into from
Oct 25, 2023

Conversation

patrickhousley
Copy link
Contributor

@patrickhousley patrickhousley commented Oct 25, 2023

Fixing missing type declarations in the feature utilities that show up when skibLibCheck is not enabled in the tsconfig.

Overview

Fixing missing type declarations in the feature utilities that show up when skibLibCheck is not enabled in the tsconfig. This also enabled lib checking in the vite wrapper test project to ensure this is not an issue in the future.

Related Issue(s)

TBD

Testing

@github-actions
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.49 kB / 10.21 kB (gzip) 29.49 kB / 10.21 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.31 kB / 14.98 kB (gzip) 45.31 kB / 14.98 kB (gzip) 0% / 0% (gzip)
pro loader 46.8 kB / 15.62 kB (gzip) 46.8 kB / 15.62 kB (gzip) 0% / 0% (gzip)
pro async-chunk 73.41 kB / 23.4 kB (gzip) 73.41 kB / 23.4 kB (gzip) 0% / 0% (gzip)
spa loader 53.22 kB / 17.59 kB (gzip) 53.22 kB / 17.59 kB (gzip) 0% / 0% (gzip)
spa async-chunk 87.87 kB / 27.75 kB (gzip) 87.87 kB / 27.75 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 121.31 kB / 39.19 kB (gzip) 121.31 kB / 39.19 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.73 kB / 17.18 kB (gzip) 57.73 kB / 17.18 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 140.83 kB / 45.07 kB (gzip) 140.83 kB / 45.07 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.25 kB / 27.19 kB (gzip) 101.25 kB / 27.19 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 148.8 kB / 47.2 kB (gzip) 148.8 kB / 47.2 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 116.4 kB / 31.63 kB (gzip) 116.4 kB / 31.63 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #791 (34b6f23) into main (e0e2af6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   77.74%   77.73%   -0.01%     
==========================================
  Files         140      140              
  Lines        6237     6235       -2     
  Branches     1211     1211              
==========================================
- Hits         4849     4847       -2     
  Misses       1184     1184              
  Partials      204      204              
Flag Coverage Δ
unit-tests 54.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/features/utils/feature-base.js 100.00% <ø> (ø)
src/features/utils/instrument-base.js 94.52% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@patrickhousley patrickhousley merged commit c80e8d2 into main Oct 25, 2023
14 of 15 checks passed
@patrickhousley patrickhousley deleted the fix-types branch October 25, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants