fix: Fix missing type declarations (#791)

newrelic · Oct 25, 2023 · c80e8d2 · c80e8d2
1 parent bc4c554
commit c80e8d2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/features/utils/feature-base.js b/src/features/utils/feature-base.js
@@ -4,9 +4,9 @@ export class FeatureBase {
   constructor (agentIdentifier, aggregator, featureName) {
     /** @type {string} */
     this.agentIdentifier = agentIdentifier
-    /** @type {Aggregator} */
+    /** @type {import('../../common/aggregate/aggregator').Aggregator} */
     this.aggregator = aggregator
-    /** @type {ContextualEE} */
+    /** @type {import('../../common/event-emitter/contextual-ee').ee} */
     this.ee = ee.get(agentIdentifier)
     /** @type {string} */
     this.featureName = featureName

diff --git a/src/features/utils/instrument-base.js b/src/features/utils/instrument-base.js
@@ -20,7 +20,7 @@ export class InstrumentBase extends FeatureBase {
   /**
    * Instantiate InstrumentBase.
    * @param {string} agentIdentifier - The unique ID of the instantiated agent (relative to global scope).
-   * @param {Aggregator} aggregator - The shared Aggregator that will handle batching and reporting of data.
+   * @param {import('../../common/aggregate/aggregator').Aggregator} aggregator - The shared Aggregator that will handle batching and reporting of data.
    * @param {string} featureName - The name of the feature module (used to construct file path).
    * @param {boolean} [auto=true] - Determines whether the feature should automatically register to have the draining
    *     of its pooled instrumentation data handled by the agent's centralized drain functionality, rather than draining
@@ -34,7 +34,7 @@ export class InstrumentBase extends FeatureBase {
     this.abortHandler = undefined
 
     /**
-     * @type {Class} Holds the reference to the feature's aggregate module counterpart, if and after it has been initialized. This may not be assigned until after page loads!
+     * @type {import('./aggregate-base').AggregateBase} Holds the reference to the feature's aggregate module counterpart, if and after it has been initialized. This may not be assigned until after page loads!
      * The only purpose of this for now is to expose it to the NREUM interface, as the feature's instrument instance is already exposed.
     */
     this.featAggregate = undefined
@@ -122,7 +122,7 @@ export class InstrumentBase extends FeatureBase {
   /**
  * Make a determination if an aggregate class should even be imported
  * @param {string} featureName
- * @param {SessionEntity} session
+ * @param {import('../../common/session/session-entity').SessionEntity} session
  * @returns
  */
   shouldImportAgg (featureName, session) {

diff --git a/tools/test-builds/vite-react-wrapper/package.json b/tools/test-builds/vite-react-wrapper/package.json
@@ -15,7 +15,6 @@
     "build": "tsc && vite build"
   },
   "devDependencies": {
-    "@types/node": "^17.0.21",
     "@types/react": "*",
     "@types/react-dom": "*",
     "@vitejs/plugin-react-swc": "3.2.0",

diff --git a/tools/test-builds/vite-react-wrapper/tsconfig.json b/tools/test-builds/vite-react-wrapper/tsconfig.json
@@ -8,7 +8,6 @@
       "ESNext"
     ],
     "allowJs": false,
-    "skipLibCheck": true,
     "esModuleInterop": false,
     "allowSyntheticDefaultImports": true,
     "strict": true,