-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Session trace nodes de-duplication (#1008)
Co-authored-by: Jordan Porter <[email protected]>
- Loading branch information
1 parent
38a502b
commit 44f229e
Showing
6 changed files
with
147 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import { testRumRequest } from '../../../tools/testing-server/utils/expect-tests.js' | ||
| import { notIE } from '../../../tools/browser-matcher/common-matchers.mjs' | ||
|
|
||
| describe('Trace nodes', () => { | ||
| const config = { init: { session_trace: { harvestTimeSeconds: 2 } } } | ||
|
|
||
| it.withBrowsersMatching(notIE)('are not duplicated for events', async () => { | ||
| const url = await browser.testHandle.assetURL('pagehide.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
|
|
||
| await browser.execute(function () { | ||
| const storedEvents = Object.values(newrelic.initializedAgents)[0].features.session_trace.featAggregate.prevStoredEvents | ||
| for (let i = 0; i < 10; i++) storedEvents.add(i) // artificially add "events" since the counter is otherwise unreliable | ||
| }) | ||
| const resPromise = browser.testHandle.expectResources() | ||
| $('#btn1').click() // since the agent has multiple listeners on vischange, this is a good example of often duplicated event | ||
| const { request } = await resPromise | ||
|
|
||
| const vischangeEvts = request.body.res.filter(node => node.t === 'event' && node.n === 'visibilitychange') | ||
| expect(vischangeEvts.length).toEqual(1) | ||
|
|
||
| // In addition, our Set keeping track of stored Events should have reset during harvest to prevent mem leak. | ||
| const trackedEventsPostHarvest = await browser.execute(getEventsSetSize) | ||
| expect(trackedEventsPostHarvest).toBeLessThan(10) | ||
| }) | ||
| it.withBrowsersMatching(notIE)('are not stored for events when trace is not on', async () => { | ||
| await browser.testHandle.scheduleReply('bamServer', { | ||
| test: testRumRequest, | ||
| body: JSON.stringify({ stn: 0, err: 1, ins: 1, cap: 1, spa: 0, loaded: 1 }) | ||
| }) | ||
|
|
||
| const url = await browser.testHandle.assetURL('pagehide.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
| await $('#btn1').click() | ||
| const numTrackedEvents = await browser.execute(getEventsSetSize) | ||
| expect(numTrackedEvents).toEqual(0) | ||
| }) | ||
| function getEventsSetSize () { | ||
| return Object.values(newrelic.initializedAgents)[0].features.session_trace.featAggregate.prevStoredEvents.size | ||
| } | ||
|
|
||
| it.withBrowsersMatching(notIE)('are not duplicated for resources', async () => { | ||
| const url = await browser.testHandle.assetURL('instrumented.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
|
|
||
| let { request } = await browser.testHandle.expectResources() | ||
| const fetchedScripts = request.body.res.filter(node => node.t === 'resource' && node.n === 'script') | ||
| expect(fetchedScripts.length).toEqual(1) // our /build/nr-__.min.js | ||
| }) | ||
|
|
||
| it('are not duplicated for history pushState', async () => { | ||
| const url = await browser.testHandle.assetURL('instrumented.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
|
|
||
| await Promise.all([browser.testHandle.expectResources(), browser.execute(function () { | ||
| history.pushState({}, '') | ||
| })]).then(([{ request: { body } }]) => { | ||
| const hist = body.res.filter(node => node.n === 'history.pushState') | ||
| expect(hist.length).toEqual(1) | ||
| expect(hist[0].t.endsWith('/instrumented.html')).toBeTruthy() | ||
| }) | ||
| }) | ||
|
|
||
| it.withBrowsersMatching(notIE)('are created and not duplicated for ajax', async () => { | ||
| const url = await browser.testHandle.assetURL('fetch.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
|
|
||
| await browser.testHandle.expectResources().then(({ request: { body } }) => { | ||
| const reqs = body.res.filter(node => node.n === 'Ajax' && node.o.endsWith('/json')) | ||
| expect(reqs.length).toEqual(1) | ||
| }) | ||
| }) | ||
|
|
||
| it('are created and not duplicated for one error', async () => { | ||
| const url = await browser.testHandle.assetURL('instrumented.html', config) | ||
| await browser.url(url).then(() => browser.waitForAgentLoad()) | ||
|
|
||
| await Promise.all([browser.testHandle.expectResources(), browser.execute(function () { | ||
| newrelic.noticeError('hello session traces i am error') | ||
| })]).then(([{ request: { body } }]) => { | ||
| const errs = body.res.filter(node => node.n === 'error' && node.o === 'hello session traces i am error') | ||
| expect(errs.length).toEqual(1) | ||
| }) | ||
| }) | ||
|
|
||
| it('are not duplicated for timings', async () => { | ||
| const url = await browser.testHandle.assetURL('instrumented.html', config) | ||
| let [{ request }] = await Promise.all([ | ||
| browser.testHandle.expectResources(), | ||
| browser.url(url).then(() => browser.waitForAgentLoad()) | ||
| ]) | ||
| const countTimings = {} | ||
| request.body.res.filter(node => node.t === 'timing').forEach(node => (countTimings[node.n] = ++countTimings[node.n] || 1)) | ||
|
|
||
| ;[{ request }] = await Promise.all([browser.testHandle.expectResources(), $('body').click()]) // click to trigger FI & LCP timings | ||
| request.body.res.filter(node => node.t === 'timing').forEach(node => (countTimings[node.n] = ++countTimings[node.n] || 1)) | ||
|
|
||
| expect(Object.values(countTimings).some(count => count > 1)).toBeFalsy() | ||
| }) | ||
| }) |
This file was deleted.
Oops, something went wrong.