Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate inventory queue #70

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Conversation

varas
Copy link
Contributor

@varas varas commented Aug 14, 2020

Description of the changes

This PR allocates a configurable inventory queue in the same fashion as metrics/events.

By doing so inventory processing flow won't block unless queue length is reached.

By defaults sets inventory queue size to 10 datasets.

I won't make this testable as inventory for integrations is likely to EOL soon.

ToDo:

  • Documentation

PR Review Checklist

Author

  • the PR should focus on a single subject. Change only relevant files to the problem you’re working on
  • clean and format the code
  • add unit tests for your changes and make sure all unit tests are passing
  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer
  • address the feedback
  • add a "ready for review" label. Only PRs with this label will be reviewed.

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@coveralls
Copy link

Pull Request Test Coverage Report for Build 208768063

  • 1 of 31 (3.23%) changed or added relevant lines in 1 file are covered.
  • 86 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 55.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/agent/agent.go 1 31 3.23%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender_vortex.go 1 73.21%
pkg/config/loader/config.go 85 70.82%
Totals Coverage Status
Change from base Build 205845102: 0.01%
Covered Lines: 8835
Relevant Lines: 15834

💛 - Coveralls

@varas varas requested a review from a team August 14, 2020 15:32
@varas varas added feature request Categorizes issue or PR as related to a new feature or enhancement. ready for review labels Aug 14, 2020
@varas varas requested a review from cristianciutea August 14, 2020 15:37
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlosroman carlosroman merged commit a7b17c6 into master Aug 14, 2020
@carlosroman carlosroman deleted the non_blocking_inventory_queue branch August 14, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants