Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Darwin build #207

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix: Darwin build #207

merged 1 commit into from
Nov 4, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Nov 4, 2020 •
edited
Loading

Fixes build for Mac (not supported by NR), broken by latest gopsutil update.

Next gopsutil release fixes this issue, see: goshttps://github.com/shirou/gopsutil/issues/958

For now this workaround points to the latest sys before the breaking change: golang/sys@85ca7c5, breaking change at golang/sys@5766fd3.

@varas varas requested a review from a team November 4, 2020 13:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 345632775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 58.002%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender.go 1 72.56%
internal/agent/event_sender_vortex.go 1 73.21%
Totals Coverage Status
Change from base Build 344086703: 0.02%
Covered Lines: 11173
Relevant Lines: 19263
💛 - Coveralls

@varas varas mentioned this pull request Nov 4, 2020
Closed
noly
noly approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@noly noly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@varas varas merged commit c5d55f9 into master Nov 4, 2020
@varas varas deleted the fix_mac-build branch November 4, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noly noly noly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varas @coveralls @noly