Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nri-prometheus version #206

Merged
merged 1 commit into from
Nov 4, 2020
Merged

update nri-prometheus version #206

merged 1 commit into from
Nov 4, 2020

Conversation

arvdias
Copy link
Contributor

@arvdias arvdias commented Nov 4, 2020

No description provided.

@arvdias arvdias requested a review from a team November 4, 2020 10:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 345298865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 58.008%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender.go 1 72.56%
pkg/metrics/sampler/sampler_routine.go 2 94.74%
Totals Coverage Status
Change from base Build 344086703: 0.02%
Covered Lines: 11174
Relevant Lines: 19263
💛 - Coveralls

noly
noly approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@noly noly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@varas varas merged commit e9e0f2f into master Nov 4, 2020
@varas varas deleted the arvdias/update-nri-prometheus-version branch November 4, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noly noly noly approved these changes

@varas varas varas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvdias @coveralls @varas @noly