Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute the conflict name with a placeholder #1993

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Compute the conflict name with a placeholder #1993

merged 1 commit into from
Jan 14, 2025

Conversation

alvarocabanas
Copy link
Contributor

Compute the conflict name with a placeholder replaced before rendering, since the conflicts field in goreleaser is not templatable.

@alvarocabanas alvarocabanas requested a review from a team as a code owner January 13, 2025 17:39
@alvarocabanas
Compute the conflict name with a placeholder replaced before renderin…
132487b 
…g, since the conflicts field in goreleaser is not templatable
@alvarocabanas alvarocabanas force-pushed the fix_non_templatable_conflicts branch from ccc83af to 132487b Compare January 13, 2025 17:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12752914448

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 57.328%
Files with Coverage Reduction New Missed Lines %
pkg/backend/telemetryapi/harvester.go 2 87.62%
pkg/metrics/sampler/sampler_routine.go 2 95.35%
Totals Coverage Status
Change from base Build 12746129182: -0.008%
Covered Lines: 15360
Relevant Lines: 26793
💛 - Coveralls

rubenruizdegauna
rubenruizdegauna approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocabanas alvarocabanas merged commit c06584d into master Jan 14, 2025
24 checks passed
@alvarocabanas alvarocabanas deleted the fix_non_templatable_conflicts branch January 14, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarocabanas @coveralls @rubenruizdegauna