Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newrelic-infra-template.yml.example #1956

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

nr-ksteinbach
Copy link
Contributor

tiny enhancement to the example config file, so that custom_attributes can be found when searching for either label or tag

tiny enhancement to the example config file, so that custom_attributes can be found when searching for either label or tag
@nr-ksteinbach nr-ksteinbach requested a review from a team as a code owner November 23, 2024 13:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11987453100

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 57.351%

Files with Coverage Reduction New Missed Lines %
internal/httpapi/httpapi.go 1 74.82%
pkg/metrics/sampler/sampler_routine.go 2 95.35%
Totals Coverage Status
Change from base Build 11888184229: 0.004%
Covered Lines: 15366
Relevant Lines: 26793

💛 - Coveralls

Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rajrohanyadav rajrohanyadav merged commit fec6b82 into master Dec 17, 2024
25 checks passed
@rajrohanyadav rajrohanyadav deleted the nr-ksteinbach-patch-1 branch December 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants