Adding fips compliant agents to Prerelease on demand workflow #1942

nr-dadams · 2024-10-25T17:42:20Z

Adds build mode field for FIPS/Non FIPS
New dockerfile for fips compliant building
publishes fips compliant agents with '_fips' naming convention

https://new-relic.atlassian.net/browse/NR-268769

.github/workflows/prerelease_linux_on_demand.yml

build/ci.mk

build/upload-schema-linux-deb-fips.yml

cmd/newrelic-infra-ctl/newrelic-infra-ctl.go

cmd/newrelic-infra-ctl/newrelic-infra-ctl-fips.go

nr-dadams · 2024-11-19T18:51:32Z

Had to make a few optimization changes after talking with @alvarocabanas , but this should be a bit cleaner and building/deploying successfully now. It is ready for another review as needed.

alvarocabanas

I left comments for the places we need to change the suffix.

build/goreleaser/linux/centos_7_amd64.yml

build/goreleaser/linux/centos_7_arm.yml

build/goreleaser/linux/centos_7_arm64.yml

build/goreleaser/linux/centos_8_amd64.yml

build/goreleaser/linux/centos_8_arm64.yml

build/upload-schema-linux-rpm-fips.yml

build/upload-schema-linux-targz-fips.yml

build/goreleaser/linux/centos_7_amd64.yml

coveralls · 2024-12-09T12:25:35Z

Pull Request Test Coverage Report for Build 12357911032

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 57.321%

Files with Coverage Reduction	New Missed Lines	%
internal/httpapi/httpapi.go	1	74.82%

Totals
Change from base Build 12233936056:	-0.004%
Covered Lines:	15358
Relevant Lines:	26793

💛 - Coveralls

build/ci.mk

… pipeline

* update goreleaser version * update empty_folders which is deprecated * Modified file_name_template to use "newrelic-infra" instead of project-name --------- Co-authored-by: alvarocabanas <[email protected]>

* add step to test fips binaries for fips compliance * add fips test action to linux prerelease workflow

nr-dadams requested a review from a team October 25, 2024 17:42

gsanchezgavier reviewed Nov 4, 2024

View reviewed changes

gsanchezgavier mentioned this pull request Nov 6, 2024

NR-291019 add fips compliant package builds newrelic/nri-flex#530

Merged

nr-dadams requested a review from a team as a code owner November 14, 2024 00:00

alvarocabanas reviewed Nov 21, 2024

View reviewed changes

alvarocabanas mentioned this pull request Nov 21, 2024

add fips upload schemas to ohi.yml newrelic/infrastructure-publish-action#163

Merged

alvarocabanas reviewed Nov 29, 2024

View reviewed changes

build/goreleaser/linux/centos_7_amd64.yml Outdated Show resolved Hide resolved

alvarocabanas force-pushed the dadams_fips_prerelease branch from 419c7fd to 623fe26 Compare December 9, 2024 12:19

alvarocabanas previously approved these changes Dec 16, 2024

View reviewed changes

alvarocabanas reviewed Dec 16, 2024

View reviewed changes

build/ci.mk Outdated Show resolved Hide resolved

alvarocabanas dismissed their stale review via 24f10d7 December 16, 2024 14:50

alvarocabanas previously approved these changes Dec 16, 2024

View reviewed changes

alvarocabanas dismissed their stale review via 777dad9 December 16, 2024 16:43

alvarocabanas previously approved these changes Dec 16, 2024

View reviewed changes

alvarocabanas dismissed their stale review via b6cc8bf December 16, 2024 17:17

nr-dadams and others added 13 commits December 17, 2024 09:15

Feat: Adding Fips compliant Infrastructure agents to prerelease build…

c554a68

… pipeline

Updating go version in fips dockerfile

755a119

Simplified pipeline. Removed docker.fips. Remove some unneeded comments.

e51e39a

Adding 'NON-FIPS' as a workflow field option

4510aa5

Removed faulty new lines

6e27d7c

Remove extraneous else

8ba7a4b

Chore: Back to 1.21

e2817ba

Editing everything to be one sign method

3252d87

Update go version

ba60278

Attempt to fix dirty git

3609222

Removing file update to check if it is the cause of gits anger

7caa2b8

Setting files as executable within git.. again

fe8db33

Removing auto IDE changes from files, adding changes requested by Alvaro

72d29bd

nr-dadams and others added 25 commits December 17, 2024 09:15

trying with different ifdef model

908a5b7

Edited binary names, and fips variable in linux on demand workflow

557bb03

added fips parameter to the package_name as needed for metadata

c8e766f

test removing fips env variable

d2aaa48

test adding check to filename

cbceb73

test again changing fips variable

ec5cf31

Set fips to an emtpy string if it is not found

dd01f4f

bugfix in docker build command

d18bcda

bugfix add missing }

31bb879

bugfix add missing -

e8d4b5f

bugfix renamed deb file to put -fips in correct spot

f96366c

bugfix renamed rpm schema add a -

a544ce2

Builder image: correct go path and update go version

b8117bc

Modify package_name to be templated

7036a02

Fix checksums for fips in apt

c971fd8

update goreleaser version (#1960)

a0b356f

* update goreleaser version * update empty_folders which is deprecated * Modified file_name_template to use "newrelic-infra" instead of project-name --------- Co-authored-by: alvarocabanas <[email protected]>

add step to test fips binaries for fips compliance (#1963)

fa32f36

* add step to test fips binaries for fips compliance * add fips test action to linux prerelease workflow

Remove unused variable

01b877f

Fix Agent_arch for container get infra-agent

117125d

Fix Agent_arch for container get infra-agent arm64

e01d16c

Fixe EOF line

62e5b60

Fix wrong target for fips prerelease

2ef78c7

Correct wrong message for make release/pkg-linux-arm64

3d83958

Remove unused target

1c91c25

Add EOF line

80a4e29

alvarocabanas force-pushed the dadams_fips_prerelease branch from 60c58a4 to 80a4e29 Compare December 17, 2024 08:18

alvarocabanas approved these changes Dec 17, 2024

View reviewed changes

alvarocabanas merged commit 1854f18 into master Dec 17, 2024
24 checks passed

alvarocabanas deleted the dadams_fips_prerelease branch December 17, 2024 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding fips compliant agents to Prerelease on demand workflow #1942

Adding fips compliant agents to Prerelease on demand workflow #1942

nr-dadams commented Oct 25, 2024 •

edited

Loading

nr-dadams commented Nov 19, 2024

alvarocabanas left a comment

coveralls commented Dec 9, 2024 •

edited

Loading

Adding fips compliant agents to Prerelease on demand workflow #1942

Adding fips compliant agents to Prerelease on demand workflow #1942

Conversation

nr-dadams commented Oct 25, 2024 • edited Loading

nr-dadams commented Nov 19, 2024

alvarocabanas left a comment

Choose a reason for hiding this comment

coveralls commented Dec 9, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12357911032

Details

💛 - Coveralls

nr-dadams commented Oct 25, 2024 •

edited

Loading

coveralls commented Dec 9, 2024 •

edited

Loading