Nr 116101 - Make TTL not mandatory in secret management command #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavSanchez
previously approved these changes
Oct 23, 2024
DavSanchez
approved these changes
Oct 24, 2024
rahulreddy15
force-pushed
the
NR-116101-make-ttl-not-mandatory-in-secret-management-command
branch
from
714122e to
c013771
Compare
…by the ValuesWithTTL interface cache.go - gatherer supports 'no ttl' and 'invalid ttl' values by just defaulting to defaultTTL binder.go - had to move errors to command.go to avoid creating a cycle dependency binder_test.go and command_test.go have been modified to test new functionality
Co-authored-by: David Sánchez <[email protected]>
Cannot multiply defaultVariablesTTL with time.Second because defaultVariablesTTL is already a time.Duration object.
Co-authored-by: David Sánchez <[email protected]>
rahulreddy15
force-pushed
the
NR-116101-make-ttl-not-mandatory-in-secret-management-command
branch
from
765261f to
361b75c
Compare
rahulreddy15
deleted the
NR-116101-make-ttl-not-mandatory-in-secret-management-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenarios handled:
If ttl is not present: use default ( DefaultTTL is used and a warning is logged to provide TTL )
If ttl is present and valid: override default ( wask as usual )
If ttl is present and invalid: throw an error ( Invalid TTL value throws error
ErrTTLInvalidand agent does not start.