NR-181096 fix: add log for size of compressed data in request #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
fix/NR-181096-add-logs-data-size-requests
branch
from
3d5dce7 to
35aaf7d
Compare
ghost
marked this pull request as ready for review
ghost
self-requested a review
|
I was wondering if it made sense to add another log item closer to the response generated by the (potentially offending) request. I see we already optionally log with the uncompressed data here but not report the (un)compressed lengths, perhaps it's not needed and we'll be able to pinpoint issues with the logs included here. Let me do an additional quick review and get back. |
DavSanchez
approved these changes
Oct 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.