feat: exclude matching metrics #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavSanchez
force-pushed
the
feat/exclude-matching-metrics
branch
from
17a684c to
f66283b
Compare
alvarocabanas
approved these changes
Aug 28, 2024
| ctx := NewContext(cfg, buildVersion, hostnameResolver, idLookupTable, sampleMatchFn) | ||
| sampleMatchFn := sampler.NewSampleMatchFn(cfg.EnableProcessMetrics, config.MetricsMap(cfg.IncludeMetricsMatchers), ffRetriever) | ||
| sampleExcludeFn := sampler.NewSampleMatchFn(cfg.EnableProcessMetrics, config.MetricsMap(cfg.ExcludeMetricsMatchers), ffRetriever) | ||
| ctx := NewContext(cfg, buildVersion, hostnameResolver, idLookupTable, sampler.IncludeSampleMatchFn(sampleMatchFn), sampler.ExcludeSampleMatchFn(sampleExcludeFn)) | ||
|
|
There was a problem hiding this comment.
Is this casting needed? I see it wasn't before, did you add it for verbosity?
There was a problem hiding this comment.
I modified NewSampleMatchFn to accept a generic MetricsMap, so for both include and exclude I do the explicit conversion. Otherwise I had to convert only ExcludeMetricsMap into an IncludeMetricsMap to be able to pass it to NewSampleMatchFn, which didn't feel right and could be confusing for the future us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.