Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New health status check and report for the status api #1908

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

alvarocabanas
Copy link
Contributor

New health status check and report for the status api, it detects if the CommandApi is not returning a 200. For example if License Key is incorrect.

@alvarocabanas alvarocabanas requested a review from a team August 9, 2024 13:49
@alvarocabanas alvarocabanas force-pushed the NR-282731_new_health_endpoint branch 13 times, most recently from 5ba3318 to f79dc59 Compare August 13, 2024 16:21
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 Just a couple of nitpicks

…the CommandApi is not returning a 200. For example if License Key is incorrect.
@alvarocabanas alvarocabanas force-pushed the NR-282731_new_health_endpoint branch from b08c05e to 83a33c9 Compare August 20, 2024 08:42
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocabanas alvarocabanas merged commit dab967b into master Aug 20, 2024
27 checks passed
@alvarocabanas alvarocabanas deleted the NR-282731_new_health_endpoint branch August 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants