Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump docker dep v24.0.9 to v26.1.5 #1901

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: bump docker dep v24.0.9 to v26.1.5 #1901

merged 1 commit into from
Jul 31, 2024

Conversation

gsanchezgavier
Copy link
Contributor

  • bumps docker dependency.
  • removes unused old replace directives
  • enables renovate dashboard

@gsanchezgavier gsanchezgavier requested a review from a team July 31, 2024 12:30
alvarocabanas
alvarocabanas approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a NIT

pkg/databind/internal/discovery/docker/docker.go
@@ -47,7 +48,7 @@ func fetch(d discovery.Container, matcher *discovery.FieldsMatcher) ([]discovery
}
defer dc.Close()

containers, err := dc.ContainerList(context.Background(), types.ContainerListOptions{})
containers, err := dc.ContainerList(context.Background(), container.ListOptions{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: since it's legacy, you may just use nolint: exhaustruct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though about it but don't want to pollute the code with nolint directives TBH

@gsanchezgavier gsanchezgavier merged commit 2634402 into master Jul 31, 2024
24 of 27 checks passed
@gsanchezgavier gsanchezgavier deleted the gsanchez/deps/bump-moby branch July 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocabanas alvarocabanas alvarocabanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsanchezgavier @alvarocabanas