Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log forwarder trace #170

Merged
merged 1 commit into from
Oct 14, 2020
Merged

fix: log forwarder trace #170

merged 1 commit into from
Oct 14, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Oct 14, 2020 •
edited
Loading

Fixes trace for log forwarder where line would be empty otherwise.

LogFw tracing feature hasn't been released yet, so consider this for next release.

@varas varas requested review from jsubirat and a team October 14, 2020 13:32
@varas varas added bug Categorizes issue or PR as related to a bug. ready for review labels Oct 14, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 306570615

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 57.485%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/integrations/v4/supervisor.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 306292887: -0.02%
Covered Lines: 10714
Relevant Lines: 18638
💛 - Coveralls

carlosroman
carlosroman approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops

@varas varas merged commit 54aec01 into master Oct 14, 2020
@varas varas deleted the fix_logfw_trace branch October 14, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsubirat jsubirat jsubirat approved these changes

@carlosroman carlosroman carlosroman approved these changes

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varas @coveralls @carlosroman @jsubirat