NR-126476: update NTP interval check on error #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
force-pushed
the
NR-126476_avoid_ntp_check
branch
from
37059ac to
5239bae
Compare
rogercoll
force-pushed
the
NR-126476_avoid_ntp_check
branch
from
5239bae to
af2690a
Compare
pkg/metrics/ntp.go
Outdated
| p.offset = total / time.Duration(len(offsets)) | ||
| p.updatedAt = p.now() | ||
| offsetSeconds := (total / time.Duration(len(offsets))).Seconds() | ||
| p.offset = &offsetSeconds |
There was a problem hiding this comment.
from what I understood, p.offset is not needed anymore, isn't it? (nor offsetSeconds)
There was a problem hiding this comment.
Totally right, fixed in 6184148
Thanks!
rogercoll
changed the title
rogercoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.