Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate NTP responses, trace if valid (NR-138875) #1684

Merged
merged 8 commits into from
Jun 27, 2023
Merged

feat: validate NTP responses, trace if valid (NR-138875) #1684

merged 8 commits into from
Jun 27, 2023

Conversation

DavSanchez
Copy link
Contributor

No description provided.

@DavSanchez DavSanchez requested a review from a team June 26, 2023 14:48
@DavSanchez DavSanchez marked this pull request as draft June 26, 2023 15:01
@DavSanchez DavSanchez marked this pull request as ready for review June 26, 2023 16:18
rubenruizdegauna
rubenruizdegauna reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I would add a test for the case of InvalidResponse (i.e. stratum=0). wdyt?

@DavSanchez
Copy link
Contributor Author

Nice! I would add a test for the case of InvalidResponse (i.e. stratum=0). wdyt?

Will do!

@DavSanchez
Copy link
Contributor Author

Nice! I would add a test for the case of InvalidResponse (i.e. stratum=0). wdyt?

Done in f78cd6f!

rubenruizdegauna
rubenruizdegauna previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🔥 🔥

rubenruizdegauna
rubenruizdegauna approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥

@DavSanchez DavSanchez merged commit 6c7c020 into master Jun 27, 2023
@DavSanchez DavSanchez deleted the feat/NR-138875-validation-inspection-ntp-responses branch June 27, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavSanchez @rubenruizdegauna