NR-118428 feat: get process sample username w/o CGO #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenruizdegauna
requested review from
a team,
alvarocabanas,
brushknight,
DavSanchez and
rogercoll
rubenruizdegauna
force-pushed
the
NR-118428_process_sample_user_wo_cgo
branch
2 times, most recently
from
e323c26 to
6a65314
Compare
rubenruizdegauna
force-pushed
the
NR-118428_process_sample_user_wo_cgo
branch
2 times, most recently
from
84e8543 to
111422d
Compare
rubenruizdegauna
force-pushed
the
NR-118428_process_sample_user_wo_cgo
branch
from
111422d to
f3d402d
Compare
DavSanchez
reviewed
Jun 14, 2023
| return "", errInvalidUidsForProcess //nolint:wrapcheck | ||
| } | ||
|
|
||
| return strconv.Itoa(int(uuids[0])), nil |
There was a problem hiding this comment.
Just a nitpick, wdyt about returning the actual numeric representation here and do the conversion inside usernameForGetent? Returning a string representation could make other usages of this function unwieldy (figure a function that accepts some uid argument and needs to get the number back from the string repr before actually working with the value 😕 )
There was a problem hiding this comment.
Good point 👍 . Changed in 8325d87
rubenruizdegauna
force-pushed
the
NR-118428_process_sample_user_wo_cgo
branch
from
8325d87 to
17dae8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.