Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add entity id in event submission #145

Merged
merged 13 commits into from
Oct 9, 2020
Merged

feat: add entity id in event submission #145

merged 13 commits into from
Oct 9, 2020

Conversation

noly
Copy link
Contributor

@noly noly commented Oct 7, 2020 •
edited
Loading

Now the agent submit events protocol V4 with the corresponding entityID.

In this PR:

  • New constructor for EventData type
  • Refactor of emitEvent func in dm/emitter
  • Increase code coverage

@noly noly changed the title Feat/register entity/add entity id event submission feat: add entity id in event submission Oct 7, 2020
@coveralls
Copy link

coveralls commented Oct 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 297531722

  • 72 of 73 (98.63%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 58.353%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/integrations/v4/dm/emitter.go 29 30 96.67%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 94.74%
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 295739555: 0.2%
Covered Lines: 11076
Relevant Lines: 18981
💛 - Coveralls

carlosroman
carlosroman previously approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noly noly requested a review from varas October 9, 2020 13:32
@noly noly merged commit 75a227c into master Oct 9, 2020
@varas varas deleted the feat/register_entity/add_entityID_event_submission branch November 12, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianciutea cristianciutea cristianciutea approved these changes

@carlosroman carlosroman carlosroman left review comments

@brushknight brushknight Awaiting requested review from brushknight

@varas varas Awaiting requested review from varas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noly @coveralls @carlosroman @cristianciutea