Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for prometheus metrics in protocol v4 #141

Merged
merged 7 commits into from
Oct 13, 2020
Merged

Added support for prometheus metrics in protocol v4 #141

merged 7 commits into from
Oct 13, 2020

Conversation

cristianciutea
Copy link
Contributor

This PR will add support for prometheus summary and histogram from sdk v4.

@cristianciutea cristianciutea requested a review from a team October 5, 2020 12:22
@coveralls
Copy link

coveralls commented Oct 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 304474463

  • 100 of 139 (71.94%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 58.421%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/integrations/v4/dm/emitter_no_register.go 0 4 0.0%
pkg/integrations/v4/dm/telemetry.go 86 92 93.48%
pkg/integrations/v4/dm/sender.go 14 21 66.67%
pkg/integrations/v4/protocol/types.go 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender.go 1 72.56%
internal/agent/event_sender_vortex.go 1 73.21%
Totals Coverage Status
Change from base Build 304158128: 0.1%
Covered Lines: 11228
Relevant Lines: 19219
💛 - Coveralls

@josemore josemore linked an issue Oct 13, 2020 that may be closed by this pull request
Implement Prometheus histogram and summary metrics support #89
Closed
carlosroman
carlosroman approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

varas
varas reviewed Oct 13, 2020
View reviewed changes
pkg/integrations/v4/dm/telemetry.go
return nil, err
}

if ph.calculate != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guard clause next time pls

varas
varas approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@varas varas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@carlosroman carlosroman merged commit 5aec3bb into master Oct 13, 2020
@carlosroman carlosroman deleted the cciutea/support_prometheus_metrics branch October 13, 2020 15:51
@cristianciutea cristianciutea mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varas varas varas approved these changes

@carlosroman carlosroman carlosroman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Prometheus histogram and summary metrics support
4 participants
@cristianciutea @coveralls @carlosroman @varas