Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends comments to clarify that these rules apply only to logs #1916

Merged

Conversation

jsubirat
Copy link
Contributor

@jsubirat jsubirat commented Feb 17, 2025

Relevant information

This PR simply adds more explanatory comments as to where the data used by the affected rules comes from. For these rules, the Logs Pipeline pre-enriches the logs with some attributes like the aws.Arn, optionally an entityId and an entity name (aws.lambda.FunctionName or aws.alb.loadBalancer, for instance) so that entity synthesis can work. More information can be found here: https://docs.newrelic.com/docs/logs/logs-context/aws-logs-in-context/ (still being reviewed)

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@otaviocarvalho
Copy link
Contributor

Linking our internal CDD for future reference. I have took a long-time to realize those AWS rules were not owned by Infra but Logs instead: https://newrelic.atlassian.net/wiki/spaces/TDP/pages/3670966562/CDD+-+Entity+Synthesis+for+Infra+AWS+entities+out+of+Logs

@otaviocarvalho otaviocarvalho merged commit 4a70f00 into newrelic:main Feb 17, 2025
4 checks passed
@jsubirat jsubirat deleted the complete_logs_aws_synthesis_comments branch February 17, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants