Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Missing AWS Elasticsearch Cluster Handling #1817

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

AravindKumar8520
Copy link
Contributor

Relevant information

Description:
This PR changes the handling of AWS Elasticsearch clusters when no match is found during a lookup. Previously, no action was taken (NO_OP). Now, an uninstrumented AWS Elasticsearch cluster will be created.

Key Changes:
Action on Miss: Changed from NO_OP to CREATE_UNINSTRUMENTED.
Entity Type: Creates an uninstrumented AWSELASTICSEARCHCLUSTER.

Implications:
Ensures an entity is always present after a lookup.
May result in uninstrumented entities that are not fully monitored.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

github-actions[bot]
github-actions bot previously approved these changes Dec 11, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@vlopeziglesias vlopeziglesias merged commit 0ea2c66 into newrelic:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants