Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Compute ext-service OpenTelemetry golden metrics from metrics instead of spans #1780

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE: Compute ext-service OpenTelemetry golden metrics from metrics instead of spans #1780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbfb4f
Compute ext-service OpenTelemetry golden metrics from metrics instead…
jack-berg Nov 11, 2024
2e5b712
Make error rate percentage
jack-berg Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions entity-types/ext-service/golden_metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ throughput:
unit: REQUESTS_PER_MINUTE
queries:
opentelemetry:
select: rate(count(*), 1 minute)
from: Span
where: span.kind LIKE 'server' OR span.kind LIKE 'consumer' OR kind LIKE 'server' OR kind LIKE 'consumer'
select: rate(count(%.server%duration), 1 minute)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect any issues defining golden metrics with wildcard syntax?

from: Metric
where: http.server.duration IS NOT NULL OR http.server.request.duration IS NOT NULL OR rpc.server.duration IS NOT NULL
newrelic-opentelemetry:
select: rate(count(apm.service.transaction.duration), 1 minute)
from: Metric
Expand All @@ -23,9 +23,9 @@ errorRate:
unit: PERCENTAGE
queries:
opentelemetry:
select: (filter(count(*), WHERE otel.status_code = 'ERROR') * 100) / count(*)
from: Span
where: span.kind LIKE 'server' OR span.kind LIKE 'consumer' OR kind LIKE 'server' OR kind LIKE 'consumer'
select: filter(count(%.server%duration), WHERE numeric(http.status_code) >= 500 OR numeric(http.response.status_code) >= 500) * 100 / count(%.server%duration)
from: Metric
where: http.server.duration IS NOT NULL OR http.server.request.duration IS NOT NULL
newrelic-opentelemetry:
select: sum(apm.service.error.count) * 100 / count(apm.service.transaction.duration)
from: Metric
Expand All @@ -43,9 +43,9 @@ responseTimeMs:
unit: MS
queries:
opentelemetry:
select: average(duration.ms)
from: Span
where: span.kind LIKE 'server' OR span.kind LIKE 'consumer' OR kind LIKE 'server' OR kind LIKE 'consumer'
select: average(convert(%.server%duration, unit OR 's', 'ms'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect any issues defining golden metrics with the convert function?

from: Metric
where: http.server.duration IS NOT NULL OR http.server.request.duration IS NOT NULL OR rpc.server.duration IS NOT NULL
newrelic-opentelemetry:
select: average(convert(apm.service.transaction.duration, unit, 'ms'))
from: Metric
Expand Down
Loading