Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OCSF entity #1756

Merged
merged 10 commits into from
Sep 26, 2024
Merged

feat: OCSF entity #1756

merged 10 commits into from
Sep 26, 2024

Conversation

RamanaReddy8801
Copy link
Contributor

Relevant information

Description: Created a new OCSF entity definition

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:35

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:40

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:48

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:48

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:51

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:51

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 12, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "TEXT": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 18, column: 9] (through reference chain: LinkedHashMap["finding_info.title"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@entityBot entityBot dismissed their stale review September 23, 2024 09:55

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-ocsf' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `entitydefinitionemitter.models.CustomGoldenMetricDefinition`, problem: String is not a valid unit for golden metrics
at [Source: (StringReader); line: 22, column: 1] (through reference chain: LinkedHashMap["finding_info.title"])

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''impact_score': wrong golden metric reference. Couldn't find a golden metric definition with key 'impact_score', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'impact_score': wrong golden metric reference. Couldn't find a golden metric definition with key 'impact_score', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''riskType': wrong golden metric reference. Couldn't find a golden metric definition with key 'riskType', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'riskType': wrong golden metric reference. Couldn't find a golden metric definition with key 'riskType', please populate 'goldenMetric' with a valid reference to an existing golden metric.

@entityBot entityBot dismissed their stale review September 23, 2024 10:31

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on synthesis - Exception: No entity matches 'EXT-OCSF' synthesis rules for the given test data: 'ocsfSample.json file - #1' data point. Please review test data and synthesis rules.

@entityBot entityBot dismissed their stale review September 23, 2024 10:31

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'Finding/Uid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'finding_info.title': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on synthesis - Exception: No entity matches 'EXT-OCSF' synthesis rules for the given test data: 'ocsfSample.json file - #1' data point. Please review test data and synthesis rules.

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2024
Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''FindingUid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'FindingUid': wrong golden metric reference. Couldn't find a golden metric definition with key 'Finding/Uid', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on Summary metrics for key ''finding_infoTitle': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'finding_infoTitle': wrong golden metric reference. Couldn't find a golden metric definition with key 'finding_info.title', please populate 'goldenMetric' with a valid reference to an existing golden metric.

* Error VALIDATING domainType: 'EXT-OCSF' on synthesis - Exception: No entity matches 'EXT-OCSF' synthesis rules for the given test data: 'ocsfSample.json file - #1' data point. Please review test data and synthesis rules.

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2024
Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-OCSF' on synthesis - Exception: No entity matches 'EXT-OCSF' synthesis rules for the given test data: 'ocsfSecurityFindingSample.json file - #1' data point. Please review test data and synthesis rules.

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2024
@otaviocarvalho otaviocarvalho merged commit 3c9ffd1 into newrelic:main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants