Update default dashboard for ext-kentik_ping to use more relevant labels #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add jitter (StdDevRtt) - fix failed pings -> dropped ping packets - use golden signal labels (latency/loss/jitter) - add billboards for each golden signal
entityBot
approved these changes
Aug 1, 2024
|
|
entityBot
approved these changes
Aug 1, 2024
|
Check automatic validations and remove the permissons that we don't put in the definition files. |
entityBot
approved these changes
Aug 13, 2024
entityBot
approved these changes
Aug 13, 2024
|
As @lujop mentioned, it is failing a few dashboard validations. Please reach out if you need support with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a dashboard update only
the default ping dashboard was incomplete in that it didn't show all expected metrics for a ping result; simple re-work here that uses more appropriate labels (latency/loss/jitter) and corrects the incorrrect 'failed pings' chart
Checklist