feat: Docker Infra container to EXT service #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Jul 26, 2024
entityBot
previously approved these changes
Jul 26, 2024
kolaarun
changed the title
mborroni
requested changes
Jul 29, 2024
| extractGuid: | ||
| attribute: entity.guid | ||
| entityType: | ||
| attribute: entity.type |
There was a problem hiding this comment.
You can delete the entityType.value because it's already defined on the conditions as SERVICE
There was a problem hiding this comment.
@mborroni , Thanks for reviewing this PR. I have updated the PR as per your suggestion.
entityBot
approved these changes
Jul 29, 2024
entityBot
previously approved these changes
Jul 29, 2024
entityBot
approved these changes
Jul 29, 2024
entityBot
previously approved these changes
Jul 29, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kolaarun
dismissed stale reviews from github-actions[bot] and entityBot
via
0dd9afd
entityBot
approved these changes
Jul 29, 2024
entityBot
approved these changes
Jul 29, 2024
mborroni
approved these changes
Jul 30, 2024
otaviocarvalho
approved these changes
Jul 30, 2024
mborroni
added a commit
to mborroni/entity-definitions
that referenced
this pull request
Jul 30, 2024
This reverts commit d0e9369.
otaviocarvalho
pushed a commit
that referenced
this pull request
Jul 30, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Relation synthesis added for NR infra docker container to EXT service
Checklist
identifierwill be unique and valid.