-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(nginx): add nginx OTel support #22554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nginx): add nginx OTel support #22554
Conversation
|
Hi @sairaj18 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Please ensure the propsed changes look good by building it first in your local environment. Refer to this contribution guide to get the site up and running in your local. If you really require a preview url, reach out to one of the writers and they will generate one for you. |
6df77cf to
114d367
Compare
114d367 to
c35c665
Compare
|
netlify build fork |
|
✅ Your PR has been mirrored to our repository as PR #22557. |
c35c665 to
b04c166
Compare
… files, create a single file for each deployment type
7ab9084 to
0b52dcd
Compare
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
| 4. Restart the collector to apply the changes: | ||
|
|
||
| ```bash | ||
| sudo systemctl restart otelcol-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed again? Since the logs are a mandatory step can we have everything included in a single step? May I know why was this split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made configuring logs optional because by default we don't want the ingest to be too high. So, this will be a separate step and users should restart the collector once they update their config to ingest logs.
| - [OpenTelemetry Collector Contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/latest) installed and running on a linux host | ||
| - Network access from the linux host to: | ||
| - NGINX HTTP stub status endpoint | ||
| - Anyone of the [New Relic OTLP](https://docs.newrelic.com/docs/opentelemetry/best-practices/opentelemetry-otlp/#configure-endpoint-port-protocol:~:text=HTTP-,Endpoint,-Supported%20ports) enpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify it to the correct URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the url.
26247f7 to
58dde37
Compare
… files, create a single file for each deployment type
58dde37 to
3b1c78e
Compare
|
netlify build fork |
…-technical users - Add comprehensive introduction with value proposition and use cases - Expand prerequisites with detailed verification steps and troubleshooting - Provide multiple NGINX configuration options with security considerations - Transform basic environment variables into comprehensive authentication setup - Completely rewrite log forwarding with structured logging and full examples - Add progressive disclosure using collapsers for complex configurations - Include verification commands and expected outputs throughout - Add comprehensive troubleshooting sections for each major step 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
… files, create a single file for each deployment type
3b1c78e to
f60a67f
Compare
- Break down complex Step 2 configuration into digestible sections - Add context before configurations with clear explanations - Improve troubleshooting with focused, actionable collapsers - Move data viewing content to dedicated Find-and-query-your-data.mdx - Fix cross-reference errors and formatting inconsistencies - Simplify authentication setup with clearer credential instructions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
… compliance - Add CollapserGroup/Collapser components to all 5 steps for better organization - Consolidate 5 scattered troubleshooting sections into one comprehensive section - Remove "Congratulations" from next steps for professional tone - Change "Getting help" to "Get help" per New Relic style guide - Improve document navigation and reduce visual overwhelm 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add comprehensive nginx-otel-metrics-reference.mdx with all metrics and attributes - Update all guides to reference dedicated metrics file instead of duplicating content - Fix MDX formatting issues in Kubernetes guide - Improve next steps section with metrics reference links 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add dashboard verification link after setup completion - Link log forwarding to metrics reference for better context - Enhance user flow from setup to data usage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add Next steps section to Kubernetes guide with data usage and related monitoring links - Add Next steps section to find-and-query guide with NRQL tutorial and alert setup links - Include Kubernetes-specific resources for advanced cluster monitoring - Improve user flow with clear continuation pathways after setup completion 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add NGINX vs NGINX Plus comparison and advantages - Restructure with numbered steps and collapsers for better navigation - Add verification steps and expected outputs - Include comprehensive Next steps section with cross-links - Improve user flow with progressive disclosure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add overview, data usage, and metrics reference pages to NGINX integration nav - Create logical user flow: overview → setup → data usage → reference - Maintain consistent navigation structure across documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
Clarify that nginx.display.name can be customized based on New Relic dashboard requirements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Clarify deployment name uniqueness is per New Relic account - Remove hardcoded ports, reference official endpoint docs - Remove validation section - Use generic timing language 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Enhanced troubleshooting sections with clearer guidance - Improved log configuration and component validation - Simplified navigation and removed outdated content - Fixed YAML indentation and link references 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
|
netlify build fork |
|
✅ Your updates have been mirrored to our repository in PR #22557. |
Quick start PR - newrelic/newrelic-quickstarts#2719
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
links to related docs, screenshots, etc.