-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update session-replay.mdx #19243
Update session-replay.mdx #19243
Conversation
After some testing, we should add expected behavior with iframe apps and session replay content.
Hi @CherylFrankenfield 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@metal-messiah or @cwli24 Would you please review this as well and make any necessary edits? thank you! |
* if *recordCrossOriginIframes* is not enabled (current state of agent) in the replay options, agents placed in both window and iframe will each report session replay events independently (with their own session) in line with the two bullets above. | ||
* if *recordCrossOriginIframes* <u>is</u> enabled and agents are in both window and iframe, the iframe agent does <u>not</u> report session replay events. However, the window agent will report events with the cross-origin iframe events captured in replay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to re-consider adding this to the documentation. There's not currently a way for customers to configure the recordCrossOriginIframes
behavior for rrweb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's remove those two bullet points then.
I made the following changes, including removing the two bullet points mentioned above: fix(browser): improved language of troubleshooting section @CherylFrankenfield @metal-messiah Please review and let me know what you think. |
Thanks!
The last bullet should read:
* If you place the browser agent in the iframe, session replay only
captures what's in the iframe.
…On Mon, Nov 11, 2024 at 3:40 PM ally sassman ***@***.***> wrote:
I made the following changes, including removing the two bullet points
mentioned above: fix(browser): improved language of troubleshooting
section
<f3f046f>
@CherylFrankenfield <https://github.com/CherylFrankenfield> @metal-messiah
<https://github.com/metal-messiah> Please review and let me know what you
think.
—
Reply to this email directly, view it on GitHub
<#19243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXXGXV6PRGYA6SFUPG3SQT2AE56BAVCNFSM6AAAAABRN3IR7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGI4TGNJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
src/content/docs/browser/browser-monitoring/browser-pro-features/session-replay.mdx
Outdated
Show resolved
Hide resolved
…es/session-replay.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
After some testing, we should add expected behavior with iframe apps and session replay content.
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
links to related docs, screenshots, etc.