Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session-replay.mdx #19243

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

CherylFrankenfield
Copy link
Contributor

After some testing, we should add expected behavior with iframe apps and session replay content.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

After some testing, we should add expected behavior with iframe apps and session replay content.
Copy link

github-actions bot commented Nov 8, 2024

Hi @CherylFrankenfield 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 025ed78
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/673dc13199f98b0008f10e3b
😎 Deploy Preview https://deploy-preview-19243--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CherylFrankenfield
Copy link
Contributor Author

@metal-messiah or @cwli24 Would you please review this as well and make any necessary edits? thank you!

Comment on lines 270 to 271
* if *recordCrossOriginIframes* is not enabled (current state of agent) in the replay options, agents placed in both window and iframe will each report session replay events independently (with their own session) in line with the two bullets above.
* if *recordCrossOriginIframes* <u>is</u> enabled and agents are in both window and iframe, the iframe agent does <u>not</u> report session replay events. However, the window agent will report events with the cross-origin iframe events captured in replay.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to re-consider adding this to the documentation. There's not currently a way for customers to configure the recordCrossOriginIframes behavior for rrweb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's remove those two bullet points then.

@ally-sassman ally-sassman self-assigned this Nov 8, 2024
@ally-sassman ally-sassman added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Nov 8, 2024
@ally-sassman
Copy link
Contributor

I made the following changes, including removing the two bullet points mentioned above: fix(browser): improved language of troubleshooting section

@CherylFrankenfield @metal-messiah Please review and let me know what you think.

@CherylFrankenfield
Copy link
Contributor Author

CherylFrankenfield commented Nov 12, 2024 via email

Copy link
Contributor

@adutta-newrelic adutta-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@adutta-newrelic adutta-newrelic merged commit 52c5191 into newrelic:develop Nov 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants