Intro & Step Component Bug Fixes #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a few different issues with the
IntroandStepcomponents (see screenshots):Since the Intro and Step components both had the concept of allowing markdown, but needing an optional component to be rendered alongside, I went ahead an abstracted that work to a
SideBySidecomponent (naming things is hard). This helped clean up those other components and provides us with a way to keep content aligned in a more uniform way.There's a minor issue with the CodeSnippet copy button on mobile, but I felt like that was out of scope of this PR.
Reviewer Notes
Our current pages should not look different, but we can now add more content to the Intro component section. We also have the ability to specify the direction of the content (left / right).
Related Issue(s) / Ticket(s)
Screenshot(s)
Good: Desktop
Bad: Desktop
Good: Mobile Intro
Bad: Mobile Intro
Good: Mobile Step (see copy button note in description)
Bad: Mobile Step
