Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing footer component test #900

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix failing footer component test #900

merged 1 commit into from
Oct 27, 2020
+129 −32

Conversation

cdanielsen
Copy link
Contributor

@cdanielsen cdanielsen commented Oct 27, 2020 •
edited
Loading

Description

  • Adds a guard for what is signaled as an optional context value to prevent a TypeError at test runtime
  • updates a stale snapshot to a corrected (if uglier) version

Reviewer Notes

Baseline develop:

$ yarn test
=> Failure in src/components/__tests__Footer.js
TypeError: Cannot read property 'includes' of undefined

Compare to this branch (test passes)

Related Issue(s) / Ticket(s)

None that I could find!

Screenshot(s)

N/A

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cdanielsen cdanielsen force-pushed the fix-failing-footer-component-test branch from e5779fb to 78cfe16 Compare October 27, 2020 07:06
@cdanielsen
Copy link
Contributor Author

Apologies for the force push 😬 / I had committed with the wrong name/email, which was borking the CLA

@jerelmiller
Copy link
Contributor

@cdanielsen no worries! We force push as well, so no harm there!

jerelmiller
jerelmiller approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you SOOOOOO much for fixing this 🎉 . Seems we probably need to enforce passing tests on PRs. I'm not sure how long this has been broken 😬

@jerelmiller jerelmiller merged commit de580f0 into newrelic:develop Oct 27, 2020
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@cdanielsen cdanielsen deleted the fix-failing-footer-component-test branch October 28, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdanielsen @CLAassistant @jerelmiller @nr-opensource-bot