Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innovation week: Updated tutorial experience #855

Merged
merged 134 commits into from
Oct 23, 2020

Conversation

jerelmiller
Copy link
Contributor

@jerelmiller jerelmiller commented Oct 16, 2020

Description

Upgrade the guide experience by providing a few new components and supercharging the code blocks. Updates the step components to better align code-blocks with the associated content.

Screenshots

Screen Shot 2020-10-23 at 10 08 56 AM

Screen Shot 2020-10-23 at 10 09 02 AM

@jerelmiller jerelmiller force-pushed the jerel/apple-style-tutorial branch from 6c61123 to cfedf24 Compare October 21, 2020 09:39
@jerelmiller jerelmiller marked this pull request as ready for review October 23, 2020 17:02
Project,
Tutorial,
TutorialStep,
TutorialSection,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of the new names. Would love to get some help on naming these components. We've received feedback that Steps and Step are too similar and hard to follow. The old names are aliased above, but I'd love to figure out a better name for this component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been really thinking about this and I still do not know what you could rename it to. I am terrible with names.

Copy link
Contributor

@caylahamann caylahamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me!!! I'm super excited and I learned a lot reading through :)

Project,
Tutorial,
TutorialStep,
TutorialSection,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been really thinking about this and I still do not know what you could rename it to. I am terrible with names.

onFinishedTyping,
}) => {
const element = animate ? (
<Typist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

@jerelmiller jerelmiller merged commit 7ed88ae into develop Oct 23, 2020
@jerelmiller jerelmiller deleted the jerel/apple-style-tutorial branch October 23, 2020 18:06
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants