-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcement Banner Fixes #725
Conversation
It looks like we may need to polyfill the
|
I fixed the build issue with |
🎉 This PR is included in version 1.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This addresses a few issues that are specific to the developer site when it comes to using the Announcement Banner:
Reviewer Notes
I added a hook called
useResizeObserver
that uses ResizeObserver under the hood. This may be helpful in other locations. At the moment, it's just set up to work with height, but we can make it more generalized if we want.Related Issue(s) / Ticket(s)
N/A
Screenshot(s)
With a Banner:

Without a Banner:
