Guide page styling #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstix
reviewed
May 28, 2020
zstix
reviewed
May 28, 2020
zstix
reviewed
May 28, 2020
zstix
reviewed
May 28, 2020
|
|
||
| <Step stepNumber="3 of 4" stepTitle="Make sure you're getting data from the right New Relic account"> | ||
|
|
||
| In your preferred text editor, open the `/add-time-picker/nerdlets/nr1-howto-add-time-picker-nerdlet/index.js` and then edit the following line to use your account ID (find your account ID in the Profile section of the Developer Center, where you downloaded the New Relic One CLI): |
There was a problem hiding this comment.
Totally out of scope of this PR, but it might be cool to add an extra prop to the CodeSnippet component to specify a filename (maybe it appears to the left of the copy bar like github gists do). I could see that being pretty helpful context for developers.
zstix
reviewed
May 28, 2020
zstix
reviewed
May 28, 2020
Zstickles/step numbers
zstix
previously approved these changes
May 29, 2020
There was a problem hiding this comment.
This looks good to me! I know I have had a hand in some of this code, so we might want @timglaser to give it some 👀
timglaser
suggested changes
May 29, 2020
jpvajda
added
documentation
zstix
added
enhancement
timglaser
previously approved these changes
Jun 2, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds components for use in mdx files and styling for the guide pages.
Reviewer Notes
The example page now lives at
/guides/example