Create attend-events.js #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jpvajda
added
events
work in progress
|
Relates to #678 |
jerelmiller
suggested changes
Aug 25, 2020
There was a problem hiding this comment.
@veextee I made a couple pretty minor comments. Thanks so much for creating this! This will be super nice to have!!
| @@ -0,0 +1,71 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
I'm not quite sure how to comment on the file as a whole, but just wanted to point out that you have this file in the root folder. Unfortunately Gatsby won't be able to see this file, so it won't actually create a page for it. Can you move this file to the src/pages directory? Gatsby will then be able to pick it up, work some magic ✨ and create a page for it.
From what I can tell otherwise, this page looks pretty good 🙂
Co-authored-by: Jerel Miller <[email protected]>
|
Closing in favor of #684 |
jpvajda
removed
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at taking Stijn's kubecon page and jemiah's nerd days page to make an "attend events" page. please edit.