fixed camel case headers and emoji error in an issue template #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmfred
reviewed
May 21, 2020
| @@ -15,7 +15,7 @@ assignees: '' | |||
| ### Description | |||
| A clear and concise description of what the bug is. | |||
|
|
|||
| ### Step To Reproduce | |||
| ### Step to reproduce | |||
|
adding @timglaser for a review as I think Zack is out |
timglaser
suggested changes
May 22, 2020
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| name: "Documentation Issue \U0001F589" | |||
| name: "Documentation Issue \U0001F4DC" | |||
There was a problem hiding this comment.
"Bug report" above is sentence cased like the markdown headers in this PR which makes me think this too should be sentence case. Thoughts?
There was a problem hiding this comment.
Yeah let me fix those issue template titles to be sentence case. good catch.
|
@timglaser I fixed that issue your reported. |
timglaser
previously approved these changes
May 22, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few typos that I wanted to fix. Also @mmfred mentioned all headers should be sentence case, not camel so I fixed that too.