Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related resources #522

Merged
merged 25 commits into from
Aug 3, 2020
Merged

Related resources #522

merged 25 commits into from
Aug 3, 2020

Conversation

jerelmiller
Copy link
Contributor

Closes #516
Closes #517

Description

Adds the ability to specify related resources for a guide in the frontmatter of the MDX document.

Screenshot(s)

Screen Shot 2020-07-31 at 11 41 09 PM

@jerelmiller jerelmiller added the enhancement New feature or request label Aug 3, 2020
src/components/Tag.js Outdated Show resolved Hide resolved
src/components/Tag.js Outdated Show resolved Hide resolved

export default {
...featherIcons,
'external-link': (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add this icon to the theme or is it more of a one-off for the dev site?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same thing. I suspect that was the intention (thus the file name).

This seems like something that would be helpful across a few sites. I'll make another PR / release for this shortly.

Copy link
Contributor

@caylahamann caylahamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@zstix zstix merged commit 9fe095f into main Aug 3, 2020
@zstix zstix deleted the jerel/related-resources branch August 3, 2020 20:49
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
5 participants