Right rail content #502
Right rail content #502
Conversation
There was a problem hiding this comment.
One minor comment about the underline.
Also, would it make sense to move src/layout/MainLayout.js to the src/components/PageLayout directory? The distinction between the two isn't super clear to me at the moment.
Lastly, I feel like the guide content gets a little squished at certain breakpoints. It probably doesn't help that this is the exact breakpoint that I use in FireFox:
Not sure if @djsauble has any opinions on this.
| <PageTitle>Observability for every developer</PageTitle> | ||
| <SEO /> | ||
| <PageLayout type={PageLayout.TYPE.SINGLE_COLUMN}> | ||
| <PageLayout.Header title="Observability for every developer" /> |
There was a problem hiding this comment.
This adds an underline to the title on the homepage, which doesn't currently exist. We might want to add a lil css override for this.
There was a problem hiding this comment.
I'm actually not seeing the underline for most of our pages. We may just want to remove this an add it where applicable.
There was a problem hiding this comment.
I added the underline intentionally on every page, including the homepage, so that every page had a consistent page title treatment. I might need to chat with @djsauble one more time and get his thoughts 😄
Not quite. I can understand the confusion, which is why I had such a hard time trying to name the We are going to want to add that related content area to more pages over time, so the thinking was to try and make this easy when we come back to this for other pages. Ideally its a switch of the From a developer point of view, I'd love to get your thoughts on this API and by all means, if you have a better name that |
|
@djsauble I think we need to figure out how we can make the content area bigger. That or maybe we need a better breakpoint for when the 2-column layout switches to a single column in the content area. |
|
@zstix After talking with @djsauble we decided to keep the underline on every page to maintain consistency with the separation of the page title and the content. I've also pushed up some changes to 1) widen the layout by 100px to help those with super-wide monitors and 2) update the breakpoint that switches the side by side content to single column. That should help people with mid-size screens see both the related content and main content area without making it feel squished. Take a look and see if this works a bit better for you! |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #476
Description
Adds a "right rail" component that houses the area to contribute to the project. The right rail only shows up on guide pages.
Screenshot(s)