Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes edit button for component docs #365

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Conversation

caylahamann
Copy link
Contributor

Description

Removes the edit button in the footer for component docs since those are generation from the SDK.

Reviewer Notes

Look at the footer for a guide and then look at it for a component or api doc.

Related Issue(s) / Ticket(s)

#334

Screenshot(s)

Screen Shot 2020-06-30 at 6 07 12 PM

@caylahamann caylahamann added the enhancement New feature or request label Jun 30, 2020
@caylahamann caylahamann added this to the Post release fixes milestone Jun 30, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

@caylahamann caylahamann linked an issue Jun 30, 2020 that may be closed by this pull request
@jerelmiller
Copy link
Contributor

@caylahamann Does the edit button still show up in the header or no?

@caylahamann
Copy link
Contributor Author

@jerelmiller yep it does! going to fix that and commit again

@caylahamann caylahamann merged commit 2d1cfdb into master Jul 1, 2020
@caylahamann caylahamann deleted the cayla/remove-edit-button branch July 1, 2020 16:30
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit button should not be displayed on Component & API doc pages
5 participants