Smaller rows for guide tiles by default #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstix
reviewed
Jun 29, 2020
|
@zstix The reason why I don't reduce the padding for tiles without a time is because it helps the titles align with each other regardless of whether the tile itself has a duration specified or not. It gets pretty complicated pretty fast if we need to do some additional logic to determine if there is a row with no durations specified, etc. You can see that in this screenshot here:
Removing the padding looks like this, which in my opinion looks a bit goofy.
|
zstix
approved these changes
Jun 29, 2020
|
Totally! |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the height of the guide tiles to avoid the huge amount of padding underneath the description.
Reviewer Notes
n/a
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.
Screenshot(s)