Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup dev env #259

Merged
merged 13 commits into from
Jun 29, 2020
Merged

Setup dev env #259

merged 13 commits into from
Jun 29, 2020

Conversation

mmfred
Copy link
Contributor

@mmfred mmfred commented Jun 25, 2020

Description

Adding set up dev env page and build-apps folder to the repo.

Reviewer Notes

If there are links or steps needed to test this work, add them here.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

@jerelmiller jerelmiller added the documentation Improvements or additions to documentation label Jun 26, 2020
mmfred added 5 commits June 27, 2020 09:42
This PR does these things:
- adds Setup your dev env content
- moves "build an app" page to the build-apps folder
- adds a couple of pages to the sidebar nav
- removes reference to integration SDK because it's not a great route to send people down.
forgot to close a step
Also, updated the nav with this new page.
worked with some step changes.
@mmfred mmfred requested a review from timglaser June 29, 2020 05:07
Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few minor things


On the [Build New Relic One applications page](https://one.newrelic.com/launcher/developer-center.launcher?pane=eyJuZXJkbGV0SWQiOiJkZXZlbG9wZXItY2VudGVyLmRldmVsb3Blci1jZW50ZXIifQ==), complete the **Quick start** steps.

These six steps get you an API key for use with developing apps, and the New Relic One CLI, for building and deploying apps. At the end of the **Quick Start**, you have a project consisting of the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you have Quick Start (capital S), and in the previous paragraph, Quick start (lowercase s). Which of these is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerelmiller - fixed this in the file. Not sure how you verify.

mmfred and others added 5 commits June 29, 2020 10:11
…e.mdx

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
…e.mdx

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one more!

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
@jerelmiller jerelmiller merged commit f9ceffd into master Jun 29, 2020
@jerelmiller jerelmiller deleted the setup-dev-env branch June 29, 2020 17:56
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants