Fixes horizontal scroll on mobile menu #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caylahamann The build should be fixed when #235 gets merged |
|
I'm still seeing a scrollbar on the mobile menu, I'll try to identify the source of the issue 🤔 |
@zstix do you know on what page you are seeing the issue? I've tried reproducing in chrome and firefox and I can't seem to see a bottom scroll bar :( |
|
@caylahamann So sorry for the slow responses. I'm seeing this on the home page (and most of the other pages too) when the menu is tall enough to the vertical scroll. Happy to hop on a quick call if you would like. |
zstix
approved these changes
Jun 29, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the horizontal scroll on mobile menu caused by a
<pre>tag.Reviewer Notes
Go to a page such as "Intro to NerdStorage" and horizontally decrease your window size, and then horizontally scroll to the right to see the bug.
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.
Screenshot(s)
Before
After