feat: new styles for subtask in lab #2033
Conversation
kisielewskik
requested review from
a team,
zstix and
josephgregoryii
and removed request for
a team
|
|
src/templates/LabOverviewTemplate.js
Outdated
| const procIdxisNotInteger = Number.isInteger( | ||
| frontmatter.procIdx | ||
| ); |
There was a problem hiding this comment.
as this is set up now procIdxisNotInteger will evaluate to true when a number is an integer. would you mind renaming it to procIdxIsInteger?
There was a problem hiding this comment.
I changed name of variable is more logic now
| width: ${procIdxIsInteger ? '100%' : '90%'}; | ||
| margin-left: ${procIdxIsInteger ? '0' : '10%'}; |
There was a problem hiding this comment.
changing the styles here have had some unintended consequences in other places that we use the GuideTiles. I think moving these styles to the LabOverviewTemplate might be best. you can use the css prop within that guidetile just like here and select for the p and h3
normal styling:
current changes:
There was a problem hiding this comment.
That spacing between the tiles seems really wide I'd recommend following the pattern we use for space between the quickstart tiles on I/O
There was a problem hiding this comment.
Totalny agree, I didn’t noticed that change will have so big impact on other views, i will move that styles to LabOverviewTemplate asap to keep website pattern, thank you for your advices
| width: ${procIdxIsInteger ? '100%' : '90%'}; | ||
| margin-left: ${procIdxIsInteger ? '0' : '10%'}; |
There was a problem hiding this comment.
That spacing between the tiles seems really wide I'd recommend following the pattern we use for space between the quickstart tiles on I/O
| } | ||
| /> | ||
| ))} | ||
| .map(({ fields, frontmatter }, index) => { |
There was a problem hiding this comment.
Attached is the screen shot for this change so it's visible, this is OK for me, so I approve this.
|
🎉 This PR is included in version 1.77.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Task from Alex Ronquillo from New Relic org. Purpose of this is making new styles for lab procedures while we have parrarel sub procedures.
Reviewer Notes
For testing it you have to make procedure with not-integer ProdIdx, example: ProcIdx 2.1, should be under ProcIdx 2 with simpler styles.