Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independently scrolled sidebar #202

Merged
merged 8 commits into from
Jun 19, 2020
Merged

Independently scrolled sidebar #202

merged 8 commits into from
Jun 19, 2020

Conversation

jerelmiller
Copy link
Contributor

Description

Update the layout to allow the sidebar to scroll independently. This moves the footer underneath the content to compensate.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

Screen Shot 2020-06-19 at 2 42 39 PM

Screen Shot 2020-06-19 at 2 42 52 PM

@djsauble
Copy link
Contributor

Be a little more generous with the spacing between the footer and the rest of the content.

It should be roughly equivalent to the spacing between the Getting Started and Build Solutions sections. 4em or so?

@jerelmiller
Copy link
Contributor Author

Perfect. Its at 2rem now so I'll double it.

@jerelmiller
Copy link
Contributor Author

jerelmiller commented Jun 19, 2020

@djsauble fixed with 37fd8a3

caylahamann
caylahamann previously approved these changes Jun 19, 2020
@zstix zstix merged commit eeef7c9 into master Jun 19, 2020
@zstix zstix deleted the jerel/scrollable-sidebar branch June 19, 2020 22:28
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants