I/O Quickstart Search & Grid Controls #1981
Conversation
Gatsby Cloud Build Reportdeveloper-website-feature/io-redesign 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
|
Had a comment on the UX here, which I don't think is caused directly by this PR, but when you click on a category, or search something in the I/O searchbox, the view jumps back to the top of the page which is very jarring. To recreate:
|
|
@rudouglas great catch - I'll try to work and see if i can get that change in this PR. If not i'll create a ticket for it 👍🏻 |
|
This looks good to me, apart from what @rudouglas pointed out. 💯 |
|
@aswanson-nr changes made! |
src/pages/instant-observability.js
Outdated
| @@ -23,6 +23,8 @@ import CATEGORIES from '../data/instant-observability-categories'; | |||
|
|
|||
| import SuperTiles from '../components/SuperTiles'; | |||
|
|
|||
| const COLLAPSE_BREAKPOINT = '760px'; | |||
There was a problem hiding this comment.
Since we're using this in multiple components now, we should break it out into the constants file. Maybe rename it to QUICKSTARTS_COLLAPSE_BREAKPOINT
There was a problem hiding this comment.
Oooo i like it. I'll get to it.
src/data/constants.js
Outdated
| @@ -50,3 +50,5 @@ export const RESERVED_QUICKSTART_IDS = { | |||
| GUIDED_INSTALL: 'GUIDED_INSTALL', | |||
| BUILD_YOUR_OWN_QUICKSTART: 'BUILD_YOUR_OWN_QUICKSTART', | |||
| }; | |||
|
|
|||
| export const COLLAPSE_BREAKPOINT = '760px'; | |||
There was a problem hiding this comment.
Okay, I'm so sorry, but let's call this something with quickstarts in the name since that's the only place it's used
|
awwwwwesome |
|
🎉 This PR is included in version 1.76.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
New styling changes and refactoring for IO