Add background for quickstarts in dark mode #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were looking a little rough in dark-mode (see before / after screenshots in the pull request). This isn't a perfect solution, but I think it looks much better than before.
Gatsby Cloud Build Reportdeveloper-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m PerformanceLighthouse report
|
|
While adding pure white can cause some visual strain on dark mode because of the high contrast, I think we can leave it as it is for now given the low traffic. That said, I'm reviewing our overall visual treatment for Dark mode and I'm working on documenting a set of improvements for Q4. No action on that for now though. |
clarkmcadoo
approved these changes
Nov 8, 2021
|
@legnaleama Thanks! this improvement actually make the overall exp. a little better, so I'm going to merge this in, but I'm looking forward to whatever you come up with. |
|
🎉 This PR is included in version 1.68.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These were looking a little rough in dark-mode (see before / after screenshots in the pull request). This isn't a perfect solution, but I think it looks much better than before.
Screenshot(s)
BEFORE
AFTER
*